Contributing

**Bug**: Verification fails for broken-routing challenge

**Steps**:
1. Copy challenge files
2. Fix both bugs
3. Run `php artisan verify broken-routing`

**Expected**: All tests pass
**Actual**: Test 3 fails with "route not found"

**Environment**: Ubuntu 22.04, PHP 8.2

**Feature**: Add "Broken API" challenge

**Use case**: Teach REST API debugging
**Value**: APIs are fundamental to modern backends
**Fits mission**: Hands-on debugging practice
**Implementation**: Challenge with JSON response bugs

<?php

namespace Core;

class ExampleClass
{
    private string $property;

    public function exampleMethod(string $param): string
    {
        if ($condition) {
            return $result;
        }

        return $default;
    }
}

// Use const/let, not var
const items = [];

// Arrow functions for callbacks
items.map(item => item.id);

// Descriptive names
function calculateTotal(items) {
    return items.reduce((sum, item) => sum + item.price, 0);
}

feat: add broken-api challenge
fix: verification fails on Windows
docs: improve routing lesson clarity
refactor: simplify Database class
test: add tests for Router class

course/challenges/your-challenge/
├── README.md              # Challenge description
├── tests.php              # Verification tests
├── routes/
│   └── routes.php        # Broken routes
├── Http/controllers/
│   └── ...               # Broken controllers
└── framework/Core/
    └── ...               # Broken framework files

// Good: Common mistake
if ($password == $hash) // Should use password_verify()

// Bad: Artificial
if (true === false) // No one writes this

// Too vague
'hint' => 'Fix the code'

// Too specific
'hint' => 'Change line 42 to: password_verify($pass, $hash)'

// Just right
'hint' => 'Use password_verify() instead of == comparison'

return [
    'bug_fixed' => [...],           // Main bug
    'no_regression' => [...],       // Didn't break other things
    'best_practice' => [...],       // Used correct approach
    'edge_cases' => [...]           // Handles edge cases
];

course/lessons/XX-topic/
├── README.md          # Lesson content
└── examples/          # Code examples (optional)

## How Routing Works

The router matches URLs to controllers:

1. Request comes in: `/posts/123`
2. Router checks patterns: `/posts/{id}`
3. Extracts parameter: `id = 123`
4. Loads controller: `posts/show.php`

// ❌ Wrong
$router->get('/posts/{id}', 'show.php');
$router->get('/posts/create', 'create.php'); // Never matches!

// ✅ Correct
$router->get('/posts/create', 'create.php');  // Specific first
$router->get('/posts/{id}', 'show.php');      // Generic after

Request → Router → Middleware → Controller → View → Response

## Practice

1. Add a route for `/about`
2. Create the controller
3. Test in browser

# Run all tests
php artisan test

# Run specific test
vendor/bin/pest tests/Feature/RouterTest.php

# With coverage
vendor/bin/pest --coverage

<?php

use function Pest\Laravel\{get, post};

it('routes to correct controller', function () {
    $router = new Core\Router();
    $router->get('/test', 'test.php');
    
    expect($router->routes['GET'])->toHaveKey('/test');
});

it('extracts route parameters', function () {
    $router = new Core\Router();
    $router->get('/posts/{id}', 'show.php');
    
    // Test parameter extraction
    $_SERVER['REQUEST_URI'] = '/posts/123';
    $_SERVER['REQUEST_METHOD'] = 'GET';
    
    $router->route('/posts/123', 'GET');
    
    expect($_GET['id'])->toBe('123');
});

## Configuration

DALT.PHP uses `.env` for configuration.

### Setup

Copy the example file:

\`\`\`bash
cp .env.example .env
\`\`\`

### Database

Configure your database:

\`\`\`bash
DB_DRIVER=sqlite
DB_DATABASE=database/app.sqlite
\`\`\`

See [Configuration Guide](/docs/reference/configuration) for all options.

## Description
Brief description of changes

## Type of Change
- [ ] Bug fix
- [ ] New feature
- [ ] Documentation
- [ ] Refactoring

## Testing
How to test these changes

## Checklist
- [ ] Tests pass
- [ ] Documentation updated
- [ ] No breaking changes

> Consider using password_verify() here

Good catch! I've updated it to use password_verify() 
for timing-safe comparison. Updated in commit abc123.

Great work on this feature! A few suggestions:

1. Consider extracting this logic into a separate method 
   for better testability
2. Add a test case for the edge case where $user is null
3. Update the README to mention this new feature

Otherwise looks good! 👍

DALT.PHP/
├── .dalt/                    # Platform internals
│   ├── Http/controllers/     # Learning UI
│   ├── resources/            # Platform assets
│   └── routes/               # Platform routes
├── app/Http/controllers/     # User controllers
├── course/                   # Learning content
│   ├── lessons/              # Lesson markdown
│   └── challenges/           # Challenge folders
├── config/                   # Configuration
├── database/                 # Migrations & SQLite
├── framework/Core/           # Framework classes
│   ├── Router.php
│   ├── Database.php
│   ├── Session.php
│   ├── Middleware/
│   └── ChallengeVerifier.php
├── public/                   # Web root
│   ├── index.php             # Entry point
│   └── router.php            # Dev server router
├── routes/                   # User routes
├── storage/                  # Logs & cache
└── tests/                    # Test suite

// In routes/routes.php
$router->get('/new-route', 'new-controller.php');

<?php
// In Http/controllers/new-controller.php

$data = ['message' => 'Hello World'];

view('new-view', $data);

# Create migration
php artisan make:migration create_table_name

# Edit: database/migrations/TIMESTAMP_create_table_name.sql

# Run migration
php artisan migrate

<?php
// In tests/Feature/NewFeatureTest.php

it('does something', function () {
    // Test code
    expect(true)->toBeTrue();
});

# Kill process on port 8000
lsof -ti:8000 | xargs kill -9

# Or use different port
php artisan serve 127.0.0.1 8080

# Clear cache
composer clear-cache

# Reinstall
rm -rf vendor
composer install

# Reset database
php artisan migrate:fresh

# Check permissions
chmod 664 database/app.sqlite
chmod 775 database/

cd .dalt
rm -rf node_modules
npm install
npm run dev